This repository has been archived by the owner on Apr 1, 2020. It is now read-only.
Feature/Fix incorrect window positions passed to buffer layers #2605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ix-incorrect-window-positions-passed-to-layer-context
Codecov Report
@@ Coverage Diff @@
## master #2605 +/- ##
=========================================
+ Coverage 45.28% 45.3% +0.01%
=========================================
Files 361 361
Lines 14575 14571 -4
Branches 1912 1912
=========================================
Hits 6601 6601
+ Misses 7750 7746 -4
Partials 224 224
Continue to review full report at Codecov.
|
bryphe
reviewed
Oct 4, 2018
| @@ -167,31 +172,33 @@ export class NeovimWindowManager extends Utility.Disposable { | |||
| currentWinId: number, | |||
| context: EventContext, | |||
| ): Promise<NeovimActiveWindowState> { | |||
| // We query the top and bottom line positions again despite these being on the context | |||
bryphe
approved these changes
Oct 4, 2018
akinsho
deleted the
feature/fix-incorrect-window-positions-passed-to-layer-context
branch
akinsho
moved this from In Progress
to Done
in Buffer Layers (Indent and Color Highlights)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a call to the
remeasurefunction to derive the window top and bottom lines as previously this was obtained from the various events and the buffer update function was passing incorrect